mobile: Mark AndroidEngineExplicitFlowTest as flaky #36426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fredy Wijaya <fredyw@google.com>
fredyw
requested review from
RyanTheOptimist,
alyssawilk and
abeyad
as code owners
abeyad
reviewed
Oct 2, 2024
| @@ -481,7 +481,7 @@ public void post_multipleRequests_randomBehavior() throws Exception { | |||
| mockWebServer.enqueue(new MockResponse().setBody("hello, world")); | |||
| RequestScenario requestScenario = | |||
| new RequestScenario() | |||
| .setHttpMethod(RequestMethod.GET) | |||
| .setHttpMethod(RequestMethod.POST) | |||
There was a problem hiding this comment.
why changing to a POST? and should the url used on the line below be changed too?
There was a problem hiding this comment.
Because the test name is post_ and there's already the one that tests GET in
I checked all the other tests and they all are correct, except this.
There was a problem hiding this comment.
Oh you mean the path. Done, I updated the path to post/, but I don't think it matters.
Signed-off-by: Fredy Wijaya <fredyw@google.com>
abeyad
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AndroidEngineExplicitFlowTest.post_multipleRequests_randomBehaviorseems to be the one that's causing the flakiness. Addingflaky = Trueand fixing the HTTP method toPOSTas what the test is intended seemed to reduce the flakiness.Risk Level: low (test only)
Testing:
bazel test --runs_per_test=100 //test/java/integration:android_engine_explicit_flow_testDocs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a