-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xray tracer: correctly annotate child spans as xray subsegments #20170
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
d63fec0
test: adding a multi-envoy test (#20016)
alyssawilk 6a86a26
Add a congestionWindowInBytes method to Envoy::Network::Connection (#…
wu-bin e7f53dd
Update QUICHE from 50f15e7a5 to cf1588207 (#20154)
alyssawilk d25664f
build(deps): bump actions/stale from 4.1.0 to 5 (#20159)
dependabot[bot] f176746
admin: improve test coverage and increase the coverage-percent thresh…
jmarantz fdec215
test: removing a bunch of direct runtime singleton access (#19993)
alyssawilk fb6f157
build(deps): bump grpcio-tools in /examples/grpc-bridge/client (#20040)
dependabot[bot] c120667
adds to spellcheck
rexnp 7e8134f
xray tracer: set subsegment type for child spans (#2)
rexnp 607c763
Xray subsegment (#3)
rexnp 491abf1
Xray subsegment (#4)
rexnp 5be2062
fixes spellcheck
rexnp a26b9b9
adds to spellcheck
rexnp cee9167
Merge branch 'envoyproxy:main' into main
rexnp 7a485f3
Merge branch 'main' of github.com:rexnp/envoy
rexnp 83e97f8
fixes spell check
rexnp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1176,6 +1176,7 @@ subnets | |
suboptimal | ||
subsecond | ||
subseconds | ||
subsegment | ||
subsequence | ||
subsetting | ||
substr | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
M-W agrees this is valid.