Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xray tracer: correctly annotate child spans as xray subsegments #20170

Merged
merged 16 commits into from
Mar 15, 2022
Merged

xray tracer: correctly annotate child spans as xray subsegments #20170

merged 16 commits into from
Mar 15, 2022

Commits on Mar 2, 2022

  1. test: adding a multi-envoy test (envoyproxy#20016) 

    Functionally this

handles the multi-envoy signal handler crash
skips instantiating a runtime singleton (off by default, must stay off until remove global runtime: rebase runtime features on ABSL_flags envoyproxy#19847 is closed)
Multi-envoy does not correctly support runtime flags or deprecation stats due to envoyproxy#19847 being incomplete. It can still handle proxy traffic client - L1 - L2 - upstream as shown in test.

Risk Level: low
Testing: yes
Docs Changes: n/a
Release Notes: n/a
Part of envoyproxy/envoy-mobile#2003

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>
    @alyssawilk @rexnp
    alyssawilk authored and rexnp committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    d63fec0 View commit details
    Browse the repository at this point in the history

  2. Add a congestionWindowInBytes method to Envoy::Network::Connection (e… 

    …nvoyproxy#20105)

Signed-off-by: Bin Wu <wub@google.com>
Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>
    @wu-bin @rexnp
    wu-bin authored and rexnp committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    6a86a26 View commit details
    Browse the repository at this point in the history

  3. Update QUICHE from 50f15e7a5 to cf1588207 (envoyproxy#20154) 

    https://github.com/google/quiche/compare/50f15e7a5..cf1588207

$ git log 50f15e7a5..cf1588207 --date=short --no-merges --format="%ad %al %s"

2022-02-28 wub Deprecate --gfe2_reloadable_flag_quic_crypto_noop_if_disconnected_after_process_chlo.
2022-02-27 vasilvv Remove QuicheMemSlice(QuicUniqueBufferPtr, size_t) constructor.
2022-02-26 fayang Use std::string instead of absl::string_view in CryptoBufferMap.
2022-02-25 bnc Ignore incoming HTTP/3 MAX_PUSH_ID frames.
2022-02-25 bnc Remove Http3DebugVisitor::OnMaxPushIdFrameSent().
2022-02-25 bnc Remove QuicSpdySession::CanCreatePushStreamWithId().
2022-02-25 fayang Deprecate gfe2_reloadable_flag_quic_single_ack_in_packet2.

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>
    @alyssawilk @rexnp
    alyssawilk authored and rexnp committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    e7f53dd View commit details
    Browse the repository at this point in the history

  4. build(deps): bump actions/stale from 4.1.0 to 5 (envoyproxy#20159) 

    Bumps [actions/stale](https://github.com/actions/stale) from 4.1.0 to 5.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v4.1.0...v5)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>
    @dependabot @rexnp
    dependabot[bot] authored and rexnp committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    d25664f View commit details
    Browse the repository at this point in the history

  5. admin: improve test coverage and increase the coverage-percent thresh… 

    …old (envoyproxy#20025)

Adds a missing test for recent lookups now that there are no more fake symbol tables. Adds tests for a variety of override methods defined in admin.h that were previously hard to hit.

Adds a benchmark test to establish a baseline for the speedups in envoyproxy#19693

Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>
    @jmarantz @rexnp
    jmarantz authored and rexnp committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    f176746 View commit details
    Browse the repository at this point in the history

  6. test: removing a bunch of direct runtime singleton access (envoyproxy… 

    …#19993)

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>
    @alyssawilk @rexnp
    alyssawilk authored and rexnp committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    fdec215 View commit details
    Browse the repository at this point in the history

  7. build(deps): bump grpcio-tools in /examples/grpc-bridge/client (envoy… 

    …proxy#20040)

Bumps [grpcio-tools](https://github.com/grpc/grpc) from 1.43.0 to 1.44.0.
- [Release notes](https://github.com/grpc/grpc/releases)
- [Changelog](https://github.com/grpc/grpc/blob/master/doc/grpc_release_schedule.md)
- [Commits](grpc/grpc@v1.43.0...v1.44.0)

---
updated-dependencies:
- dependency-name: grpcio-tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>
    @dependabot @rexnp
    dependabot[bot] authored and rexnp committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    fb6f157 View commit details
    Browse the repository at this point in the history

  8. adds to spellcheck 

    Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>
    @rexnp
    rexnp committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    c120667 View commit details
    Browse the repository at this point in the history

  9. xray tracer: set subsegment type for child spans (#2) 

    * xray tracer: set subsegment type for child spans

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

* adds test coverage

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>
    @rexnp
    rexnp committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    7e8134f View commit details
    Browse the repository at this point in the history

  10. Xray subsegment (#3) 

    * xray tracer: set subsegment type for child spans

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

* adds test coverage

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

* updates xray subsegment name to use operation name (instead of parent's span name)

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

* updates doc

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

* updates doc

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>
    @rexnp
    rexnp committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    607c763 View commit details
    Browse the repository at this point in the history

  11. Xray subsegment (#4) 

    * xray tracer: set subsegment type for child spans

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

* adds test coverage

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

* updates xray subsegment name to use operation name (instead of parent's span name)

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

* updates doc

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

* updates doc

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

* adds to spell check dictionary

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>
    @rexnp
    rexnp committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    491abf1 View commit details
    Browse the repository at this point in the history

  12. fixes spellcheck 

    Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>
    @rexnp
    rexnp committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    5be2062 View commit details
    Browse the repository at this point in the history

  13. adds to spellcheck 

    Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

xray tracer: set subsegment type for child spans (#2)

* xray tracer: set subsegment type for child spans

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

* adds test coverage

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

Xray subsegment (#3)

* xray tracer: set subsegment type for child spans

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

* adds test coverage

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

* updates xray subsegment name to use operation name (instead of parent's span name)

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

* updates doc

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

* updates doc

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

Xray subsegment (#4)

* xray tracer: set subsegment type for child spans

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

* adds test coverage

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

* updates xray subsegment name to use operation name (instead of parent's span name)

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

* updates doc

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

* updates doc

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

* adds to spell check dictionary

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>

fixes spellcheck

Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>
    @rexnp
    rexnp committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    a26b9b9 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'envoyproxy:main' into main

    @rexnp
    rexnp authored Mar 2, 2022
    Configuration menu
    Copy the full SHA
    cee9167 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'main' of github.com:rexnp/envoy 

    Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>
    @rexnp
    rexnp committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    7a485f3 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. fixes spell check 

    Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com>
    @rexnp
    rexnp committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    83e97f8 View commit details
    Browse the repository at this point in the history