Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split verify_examples tests #13195

Merged
merged 3 commits into from
Sep 21, 2020

Conversation

phlax
Copy link
Member

@phlax phlax commented Sep 19, 2020

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: examples/ci: spit verify_examples tests
Additional Description:
This allows you to run verify_build_configs and run_examples independently,
making it easier to verify an added sandbox locally.

Risk Level: low
Testing: yep
Docs Changes: to follow
Release Notes:
[Optional Runtime guard:] touch #13084
[Optional Fixes #Issue]
[Optional Deprecated:]

This allows you to run `verify_build_configs` and `run_examples` independently,
making it easier to verify an added sandbox locally.

Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
dio
dio previously approved these changes Sep 21, 2020
Copy link
Member

@dio dio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to ask a better "printing help" facility. But, tried running it myself, this one is good enough for now.

Looks good. Thanks!

Signed-off-by: Ryan Northey <ryan@synca.io>
@mattklein123 mattklein123 merged commit 0db18a6 into envoyproxy:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants