safer example runner

[ronaldpetty]

Title: safer example runner

Description:

I just used envoy/examples/verify-common.sh and during its cleanup it does a docker prune, which removes ALL stopped containers. I have dozens of containers in the stop state and use them for various unrelated activities. While I did read the script, I didn't put it together that "verify-...." was going to remove things it didn't own. I recommend injecting id information on these related containers and only delete them. Maybe via ENV, or something like that. If others think that is a good idea (or maybe just adding documentation or a feature gate on delete) I am open to implementing it.

[mattklein123]

cc @phlax

[phlax]

hi @ronaldpetty apologies for this.

I originally wrapped this test in a docker-in-docker container partly for this reason.

the wrapper wasnt added to the ci pipeline - but im thinking to add at least some documentation to make it easy to run these tests in an isolated way

[ronaldpetty]

Hi @phlax, not a problem, I am new here :). Happy to help if you have something at some point! Maybe close for now?

…

On Mon, Sep 14, 2020 at 11:29 AM phlax ***@***.***> wrote: hi @ronaldpetty <https://github.com/ronaldpetty> apologies for this. I originally wrapped this test in a docker-in-docker container partly for this reason. the wrapper wasnt added to the ci pipeline - but im thinking to add at least some documentation to make it easy to run these tests in an isolated way — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13084 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKTOY2X3W4TK2V7O7OQQTTSFZOJ5ANCNFSM4RLZIGJA> .

[phlax]

Maybe close for now?

lets keep it open until i add the relevant docs

[phlax]

@ronaldpetty thinking about this further - im realising its an issue just running a single verify.sh script.

Im gonna PR so it prunes in ci as required, but not when you run individual tests

[ronaldpetty]

That sounds right. I was digging into examples and still trying to see how to run them.

…

On Mon, Sep 14, 2020 at 11:50 AM phlax ***@***.***> wrote: @ronaldpetty <https://github.com/ronaldpetty> thinking about this further - im realising its an issue just running a single verify.sh script. Im gonna PR so it prunes in ci as required, but not when you run individual tests — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13084 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKTOY4A735LSNVUJZ3RHMTSFZQYVANCNFSM4RLZIGJA> .

[phlax]

after testing this further, it turns out that the prune isnt required at all.