Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build failure if OS doesn't support IPV6_TRANSPARENT #12956

Merged
merged 1 commit into from
Sep 2, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/common/api/posix/os_sys_calls_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ bool OsSysCallsImpl::supportsUdpGso() const {
}

bool OsSysCallsImpl::supportsIpTransparent() const {
#if !defined(__linux__)
#if !defined(__linux__) || !defined(IPV6_TRANSPARENT)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could probably just remove !defined(__linux__)? I don't feel strongly about it either way.

return false;
#else
// The linux kernel supports IP_TRANSPARENT by following patch(starting from v2.6.28) :
Expand Down