fix build failure if OS doesn't support IPV6_TRANSPARENT #12956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bill Gallagher <bgallagher@lyft.com>
|
I think this is right but maybe one of the reviewers of the offending PR wants to take a look? @mattklein123 @danzh2010 @chadr123 |
mattklein123
approved these changes
Sep 2, 2020
| @@ -111,7 +111,7 @@ bool OsSysCallsImpl::supportsUdpGso() const { | |||
| } | |||
|
|
|||
| bool OsSysCallsImpl::supportsIpTransparent() const { | |||
| #if !defined(__linux__) | |||
| #if !defined(__linux__) || !defined(IPV6_TRANSPARENT) | |||
There was a problem hiding this comment.
You could probably just remove !defined(__linux__)? I don't feel strongly about it either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bill Gallagher bgallagher@lyft.com
Commit Message: fix build failure if OS doesn't support IPV6_TRANSPARENT
Additional Description: the build currently fails with: external/envoy/source/common/api/posix/os_sys_calls_impl.cc:145:51: error: use of undeclared identifier 'IPV6_TRANSPARENT'
Risk Level: low