Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: introduce TypedExtensionConfig. #11105

Merged
merged 3 commits into from
May 7, 2020
Merged

Conversation

htuch
Copy link
Member

@htuch htuch commented May 7, 2020

A common wrapper for name/Any that should be used for all new extensions
throughout the API.

I've left a note that we need to revisit existing typed_config at the
next major version as well, since that would be a breaking change.

Signed-off-by: Harvey Tuch htuch@google.com

A common wrapper for name/Any that should be used for all new extensions
throughout the API.

I've left a note that we need to revisit existing typed_config at the
next major version as well, since that would be a breaking change.

Signed-off-by: Harvey Tuch <htuch@google.com>
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.
CC @envoyproxy/api-watchers: FYI only for changes made to api/.

🐱

Caused by: #11105 was opened by htuch.

see: more, trace.

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks.

@repokitteh-read-only repokitteh-read-only bot removed the api label May 7, 2020
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, small comment.

/wait

api/envoy/config/core/v3/extension.proto Outdated Show resolved Hide resolved
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch htuch merged commit b16981f into envoyproxy:master May 7, 2020
@htuch htuch deleted the typed-config branch May 7, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants