-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
api: introduce TypedExtensionConfig. (#11105)
A common wrapper for name/Any that should be used for all new extensions throughout the API. I've left a note that we need to revisit existing typed_config at the next major version as well, since that would be a breaking change. Signed-off-by: Harvey Tuch <htuch@google.com>
- Loading branch information
Showing
5 changed files
with
129 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
syntax = "proto3"; | ||
|
||
package envoy.config.core.v3; | ||
|
||
import "google/protobuf/any.proto"; | ||
|
||
import "udpa/annotations/status.proto"; | ||
import "validate/validate.proto"; | ||
|
||
option java_package = "io.envoyproxy.envoy.config.core.v3"; | ||
option java_outer_classname = "ExtensionProto"; | ||
option java_multiple_files = true; | ||
option (udpa.annotations.file_status).package_version_status = ACTIVE; | ||
|
||
// [#protodoc-title: Extension configuration] | ||
|
||
// Message type for extension configuration. | ||
// [#next-major-version: revisit all existing typed_config that doesn't use this wrapper.]. | ||
message TypedExtensionConfig { | ||
// The name of an extension. This is not used to select the extension, instead | ||
// it serves the role of an opaque identifier. | ||
string name = 1 [(validate.rules).string = {min_len: 1}]; | ||
|
||
// The typed config for the extension. The type URL will be used to identify | ||
// the extension. In the case that the type URL is *udpa.type.v1.TypedStruct*, | ||
// the inner type URL of *TypedStruct* will be utilized. See the | ||
// :ref:`extension configuration overview | ||
// <config_overview_extension_configuration>` for further details. | ||
google.protobuf.Any typed_config = 2 [(validate.rules).any = {required: true}]; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
syntax = "proto3"; | ||
|
||
package envoy.config.core.v4alpha; | ||
|
||
import "google/protobuf/any.proto"; | ||
|
||
import "udpa/annotations/status.proto"; | ||
import "udpa/annotations/versioning.proto"; | ||
import "validate/validate.proto"; | ||
|
||
option java_package = "io.envoyproxy.envoy.config.core.v4alpha"; | ||
option java_outer_classname = "ExtensionProto"; | ||
option java_multiple_files = true; | ||
option (udpa.annotations.file_status).package_version_status = NEXT_MAJOR_VERSION_CANDIDATE; | ||
|
||
// [#protodoc-title: Extension configuration] | ||
|
||
// Message type for extension configuration. | ||
// [#next-major-version: revisit all existing typed_config that doesn't use this wrapper.]. | ||
message TypedExtensionConfig { | ||
option (udpa.annotations.versioning).previous_message_type = | ||
"envoy.config.core.v3.TypedExtensionConfig"; | ||
|
||
// The name of an extension. This is not used to select the extension, instead | ||
// it serves the role of an opaque identifier. | ||
string name = 1 [(validate.rules).string = {min_len: 1}]; | ||
|
||
// The typed config for the extension. The type URL will be used to identify | ||
// the extension. In the case that the type URL is *udpa.type.v1.TypedStruct*, | ||
// the inner type URL of *TypedStruct* will be utilized. See the | ||
// :ref:`extension configuration overview | ||
// <config_overview_extension_configuration>` for further details. | ||
google.protobuf.Any typed_config = 2 [(validate.rules).any = {required: true}]; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
34 changes: 34 additions & 0 deletions
34
generated_api_shadow/envoy/config/core/v4alpha/extension.proto
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.