-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
objective-c: run clang-format on Objective-C files #54
Conversation
Signed-off-by: Michael Rebello <mrebello@lyft.com>
Signed-off-by: Michael Rebello <mrebello@lyft.com>
Signed-off-by: Michael Rebello <mrebello@lyft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! One small TODO request. Thanks.
@@ -1,8 +1,10 @@ | |||
#import <Foundation/Foundation.h> | |||
#import <UIKit/UIKit.h> | |||
|
|||
// NOLINT(namespace-envoy) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should fix the upstream formatter to make this configurable so we can ignore this check on particular paths. Can you add a TODO in check_format.sh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, done
Signed-off-by: Michael Rebello <mrebello@lyft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
.clang-format
symlink to upstream Envoy with a custom file for this repository.clang-format
file mirror upstream and add Objective-C rules. 2 spaces were selected in order to match upstream's C++ formattingEnvoy.framework
and start linting Objective-C#53
Signed-off-by: Michael Rebello mrebello@lyft.com