Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

objective-c: run clang-format on Objective-C files #53

Closed
rebello95 opened this issue Jun 7, 2019 · 1 comment
Closed

objective-c: run clang-format on Objective-C files #53

rebello95 opened this issue Jun 7, 2019 · 1 comment
Assignees
@rebello95
Labels
ci platform/ios Issues related to iOS
Milestone
v0.1 "Antipasto"

Comments

@rebello95
Copy link
Contributor

We should run this formatter on Objective-C files just like we do for C++.

cc @goaway @mattklein123 @junr03
@rebello95 rebello95 added platform/ios Issues related to iOS ci labels Jun 7, 2019
@rebello95 rebello95 added this to the v0.1 "Antipasto" milestone Jun 7, 2019
@rebello95 rebello95 self-assigned this Jun 7, 2019
@rebello95 rebello95 mentioned this issue Jun 7, 2019
Merged
@rebello95
Copy link
Contributor Author

#54

rebello95 added a commit that referenced this issue Jun 7, 2019
@rebello95
objective-c: run clang-format on Objective-C files (#54)
ff7c72e 
- Replace the `.clang-format` symlink to upstream Envoy with a custom file for this repository
- Rules in this `.clang-format` file mirror upstream and add Objective-C rules. 2 spaces were selected in order to match upstream's C++ formatting
- Update the format check script to ignore `Envoy.framework` and start linting Objective-C
- Run the formatter against Objective-C files

#53

Signed-off-by: Michael Rebello <mrebello@lyft.com>
@Augustyniak Augustyniak mentioned this issue Nov 2, 2022
Closed
jpsim pushed a commit to envoyproxy/envoy that referenced this issue Nov 28, 2022
@rebello95 @jpsim
objective-c: run clang-format on Objective-C files (#54)
ffee372 
- Replace the `.clang-format` symlink to upstream Envoy with a custom file for this repository
- Rules in this `.clang-format` file mirror upstream and add Objective-C rules. 2 spaces were selected in order to match upstream's C++ formatting
- Update the format check script to ignore `Envoy.framework` and start linting Objective-C
- Run the formatter against Objective-C files

envoyproxy/envoy-mobile#53

Signed-off-by: Michael Rebello <mrebello@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit to envoyproxy/envoy that referenced this issue Nov 29, 2022
@rebello95 @jpsim
objective-c: run clang-format on Objective-C files (#54)
ab74e66 
- Replace the `.clang-format` symlink to upstream Envoy with a custom file for this repository
- Rules in this `.clang-format` file mirror upstream and add Objective-C rules. 2 spaces were selected in order to match upstream's C++ formatting
- Update the format check script to ignore `Envoy.framework` and start linting Objective-C
- Run the formatter against Objective-C files

envoyproxy/envoy-mobile#53

Signed-off-by: Michael Rebello <mrebello@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rebello95 rebello95

Labels
ci platform/ios Issues related to iOS
Projects
None yet
Milestone
v0.1 "Antipasto"
Development

No branches or pull requests
1 participant
@rebello95