Match test node type to test build type

[HCastano]

While working on #437 I ran into an issue where my tests were failing because they
expected my node to have been built in release mode. This is because the tests helpers
were previously hardcoded to expect a release binary and nothing else.

This PR changes that behaviour so that the test helpers will now expect a binary
depending on the build type of the tests. I.e, if you're building your tests in debug
mode it expect a debug node, and if you built them in release mode it expects a release
node.

It also adds a couple more checks in case you don't have the right node type built.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
entropy-core	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 20, 2023 5:24pm

[HCastano]

In the future we can probably have the TestNodeProcess and builder take a Path instead, but I didn't want to mess with that here

[JesseAbram]

tbh I don't love this as I warn people not to build the chain in debug type, I have seen a lot of errors as blockchains are time dependent and you can get weird failures when you aren't optimizing the build

[HCastano]

For development it's totally reasonable to build in debug mode though.

And this doesn't remove the ability for people to run in release mode, it just makes that more explicit and less error prone.

[ameba23]

Is this working for people? My end, the server tests almost always fail when entropy is built in debug mode.

So in practice this change means i have to always build server in release mode to run the tests, which slows things down.

Since i am mostly working on server, for me it would be most convenient to build server in debug mode and run tests against a release build of entropy.

@HCastano

[HCastano]

@ameba23 all the server tests pass on my end using debug mode (on an admittedly fast laptop). Which tests are failing for you?

Having a hard requirement on needing release builds for tests to pass seems like a failure of our testing process. Everything should always be able to pass in debug mode.

[ameba23]

@ameba23 all the server tests pass on my end using debug mode (on an admittedly fast laptop). Which tests are failing for you?

Pretty much all of them fail whilst trying to get the rpc here:

entropy-core/crypto/testing-utils/src/substrate_context.rs

Line 55 in a327ee4

proc.unwrap()

eg:

thread 'user::tests::test_register_with_private_key_visibility' panicked at /home/turnip/radish/src/entropy/entropy-core/crypto/testing-utils/src/substrate_context.rs:55:10:
called `Result::unwrap()` on an `Err` value: "Failed to connect to node rpc at ws://127.0.0.1:9944 after 6 attempts: Rpc error: RPC error: Networking or low-level protocol error: Error when opening the TCP socket: Connection refused (os error 111)"

They do occasionally pass though.