Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove is_swapping from registration details #437

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Conversation

HCastano
Copy link
Collaborator

This was originally used for swapping threshold keys, but it doesn't look like it's
used anymore.

From conversations with peeps it does seem like this is something that could come back in
the future (potentially with Centralized Key Generation), but it would have to be
redesigned anyways.

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
entropy-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 10:28pm

@HCastano
Copy link
Collaborator Author

HCastano commented Oct 19, 2023

@JesseAbram the user::tests::test_register_with_private_key_visibility test is flaky for me, so I'm having a hard time telling if it's failing due to this PR.

If I run it back to back on master it passes the first time and then fails. I have the same node running between both test runs (cargo run -p entropy --dev).

Edit: It has to do with a requirement to run the node in release mode. I opened another PR to fix this

@HCastano HCastano merged commit 2cb40a5 into master Oct 20, 2023
5 checks passed
@HCastano HCastano deleted the hc-remove-is-swapping branch October 20, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants