Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace outdated --ws-external with --rpc-external #424

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Replace outdated --ws-external with --rpc-external #424

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90c6724
Update README.md
jawndiego Oct 11, 2023
9475471
changed remaining references of --ws-external to --rpc-external
jawndiego Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions README.md
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also change the other instances where --ws-external is used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops thanks!

Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,19 @@ cargo build --release
Spinning up a local Entropy node for development and basic testing can be done with:

```sh
cargo run --release -p entropy -- --dev --ws-external
cargo run --release -p entropy -- --dev --rpc-external
```

Once built, the binary can also be run directly with:

```sh
./target/release/entropy --dev --ws-external
./target/release/entropy --dev --rpc-external
```

Optionally, you can also run it with detailed logging:

```bash
RUST_BACKTRACE=1 ./target/release/entropy -ldebug --dev --ws-external
RUST_BACKTRACE=1 ./target/release/entropy -ldebug --dev --rpc-external
```

### Testing
Expand Down Expand Up @@ -67,12 +67,12 @@ Then run the following command to start a single node development chain.

This command will firstly compile your code, and then start a local development network. You can
also replace the default command
(`cargo build --release && ./target/release/entropy --dev --ws-external`)
(`cargo build --release && ./target/release/entropy --dev --rpc-external`)
by appending your own. A few useful ones are as follow.

```bash
# Run Substrate node without re-compiling
./scripts/docker_run.sh ./target/release/entropy --dev --ws-external
./scripts/docker_run.sh ./target/release/entropy --dev --rpc-external

# Purge the local dev chain
./scripts/docker_run.sh ./target/release/entropy purge-chain --dev
Expand Down