Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace outdated --ws-external with --rpc-external #424

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

jawndiego
Copy link
Contributor

@jawndiego jawndiego commented Oct 11, 2023

replacing the --ws-external to --rpc-external in the start up scripts so we can properly spin up local entropy nodes.

adding the flag:
--rpc-external 

--ws-external fails
@vercel
Copy link

vercel bot commented Oct 11, 2023

@jawndiego is attempting to deploy a commit to the entropyxyz Team on Vercel.

To accomplish this, @jawndiego needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also change the other instances where --ws-external is used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops thanks!

@HCastano
Copy link
Collaborator

Can you also update the PR description to better indicate what the change is?

@HCastano HCastano changed the title Update README.md Replace outdated --ws-external with --rpc-external Oct 12, 2023
Copy link
Collaborator

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also changed the PR title if that's alright 😄

@HCastano HCastano merged commit aa26acd into master Oct 12, 2023
4 checks passed
@HCastano HCastano deleted the jawndiego-patch-1 branch October 12, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants