-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Free TX - free tx every era; governance can update free tx per era #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
governance can set/disable free tx per era updated mock runtime and with existing tests
jakehemmerle
force-pushed
the
jh/free-tx-per-era
branch
from
August 31, 2022 22:35
42d9d0d
to
aa38da8
Compare
jakehemmerle
force-pushed
the
jh/free-tx-per-era
branch
from
August 31, 2022 22:58
5bd37a0
to
c07baa9
Compare
JesseAbram
previously approved these changes
Sep 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe making the root call allowed to be changed by council, but that can be a seperate PR
jakehemmerle
force-pushed
the
jh/free-tx-per-era
branch
2 times, most recently
from
September 1, 2022 15:52
42ef360
to
5ce4ef3
Compare
jakehemmerle
force-pushed
the
jh/free-tx-per-era
branch
from
September 1, 2022 15:55
5ce4ef3
to
2679830
Compare
JesseAbram
approved these changes
Sep 7, 2022
Closed
fjarri
pushed a commit
that referenced
this pull request
May 5, 2023
) * feat: free tx per era governance can set/disable free tx per era updated mock runtime and with existing tests * added tests * updated tests, need to fix era updates in tests * jesse couldnt even figure this one out!! * cleanup * cleanup 2 * removed unneeded comment * cleaned up tests * linting * fixed benchmarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feats and updated tests for:
Closes both above tickets. This does NOT include any sybil resistance.