fix(daemon): Handle server response error #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
commented
Mar 18, 2024
Comment on lines
+87
to
+88
| // TODO: Log this error locally. | ||
| tryRespondWithError(res); |
There was a problem hiding this comment.
Should we log something here?
This comment was marked as resolved.
This comment was marked as resolved.
rekmarks
force-pushed
the
rekmarks-handle-server-error
branch
from
39d60a3 to
ac44064
Compare
kriskowal
approved these changes
Mar 18, 2024
Comment on lines
+87
to
+88
| // TODO: Log this error locally. | ||
| tryRespondWithError(res); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes our error handling logic for the daemon's web server following #2148.