refactor(daemon,cli): Serve one weblet per fixed HTTP port. #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
force-pushed
the
kriskowal-endo-reconstruct-weblets-1921
branch
2 times, most recently
from
b89aee5 to
a886ef1
Compare
rekmarks
requested changes
Mar 15, 2024
|
|
||
| if (respond) { | ||
| server.on('request', (req, res) => { | ||
| (async () => { |
There was a problem hiding this comment.
What's the purpose of the IIFE? The callback itself can't be async?
There was a problem hiding this comment.
An async callback produces a dangling promise, which means the error can only surface as an unhandled rejection. Exceptions should be deliberately observed.
packages/cli/demo/README.md
Outdated
| @@ -257,7 +257,7 @@ _Familiar Chat_ is an example application that provides a web app for | |||
| interacting with your pet daemon. | |||
|
|
|||
| ``` | |||
| > endo install familiar-chat cat.js --powers SELF | |||
| > endo install familiar-chat cat.js 8920 --powers SELF | |||
There was a problem hiding this comment.
Wrong parameter order:
Suggested change
| > endo install familiar-chat cat.js 8920 --powers SELF | |
| > endo install familiar-chat 8920 cat.js --powers SELF |
There was a problem hiding this comment.
In light of this, perhaps we should add some parameter validation in the CLI for the name, port, and program path?
There was a problem hiding this comment.
Done, and changed --name and --port to required flags instead of a positional arguments.
12 tasks
kriskowal
force-pushed
the
kriskowal-endo-reconstruct-weblets-1921
branch
from
a886ef1 to
bd71c50
Compare
kriskowal
force-pushed
the
kriskowal-endo-reconstruct-weblets-1921
branch
from
bd71c50 to
2d946cf
Compare
kriskowal
force-pushed
the
kriskowal-endo-reconstruct-weblets-1921
branch
from
2d946cf to
3fa3d9b
Compare
rekmarks
added a commit
that referenced
this pull request
Mar 18, 2024
Completes our error handling logic for the daemon's web server following #2148.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1921
Description
This stack of individually reviewable commits fully decouples the platform-specific weblet implementation from the platform-agnostic daemon, turning it into a Node.js-specific unconfined worklet.
Removing the allegëd
typefrom formula identifiers entirely increased the urgency of fixing #1921. The new weblet architecture does not require a special web bundle type or any of the other weird coupling issues they have with wildcard subdomains. That refactor is bundled with this fix.Also motivated by weblets,
evalformulas now receive both$cancelledand$idendowments. The$idendowment is necessary for weblets to recognize their own access token, a path constructed from a prefix of their own formula identifier. I’ve renamed thecancelledendowment because I could not in good conscience claim the globalid, and this made the two names consistent.Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Compatibility Considerations
Upgrade Considerations
*BREAKING*:in the commit message with migration instructions for any breaking change.NEWS.mdfor user-facing changes.