Fix use of ip_address_validators for Django 5.1+ #9180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting this to draft for now. That Django commit was not merged into 5.0 (my bad) but into main so will only cause issue in a later Django release. Will resurrect this when there's an actual Django release with the commit. |
cclauss
added a commit
to cclauss/django-rest-framework
that referenced
this pull request
Dec 10, 2023
cclauss
added a commit
to cclauss/django-rest-framework
that referenced
this pull request
Dec 10, 2023
kiendang
commented
Dec 14, 2023
kiendang
changed the title
auvipy
approved these changes
Jan 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ip_address_validatorsreturn value changed in Django 5.1. Before Django 5.1,ip_address_validatorsreturns a tuple containing 1) the list of validators and 2) the error message. Starting from Django 5.1ip_address_validatorsonly returns the list of validators. See django/django#17305. This make tests fail withValueError: not enough values to unpack (expected 2, got 1).This PR creates a compatibility shim for
ip_address_validatorsfor Django < 5.1 to behave the same way as in Django >= 5.1.