added python 3.12 to CI #9157

auvipy · 2023-11-05T05:26:37Z

related #9181

into py312

MarkoM-dot · 2023-11-26T23:11:20Z

I am running python3.12 and get the same error as your 3.12 ci see sample.

/home/markom-dot/research/django-rest-framework/.venv/lib64/python3.12/site-packages/coreapi/utils.py:5: DeprecationWarning: pkg_
resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
  import pkg_resources
/home/markom-dot/research/django-rest-framework/.venv/lib64/python3.12/site-packages/coreapi/codecs/download.py:5: DeprecationWar
ning: 'cgi' is deprecated and slated for removal in Python 3.13
  import cgi
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/home/markom-dot/research/django-rest-framework/.venv/lib64/python3.12/site-packages/_pytest/main.py", lin
e 267, in wrap_session
INTERNALERROR>     config._do_configure()
INTERNALERROR>   File "/home/markom-dot/research/django-rest-framework/.venv/lib64/python3.12/site-packages/_pytest/config/__init
__.py", line 1053, in _do_configure
INTERNALERROR>     self.hook.pytest_configure.call_historic(kwargs=dict(config=self))
INTERNALERROR>   File "/home/markom-dot/research/django-rest-framework/.venv/lib64/python3.12/site-packages/pluggy/_hooks.py", li
ne 514, in call_historic
INTERNALERROR>     res = self._hookexec(self.name, self._hookimpls, kwargs, False)
INTERNALERROR>           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/home/markom-dot/research/django-rest-framework/.venv/lib64/python3.12/site-packages/pluggy/_manager.py", 
line 115, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
INTERNALERROR>            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/home/markom-dot/research/django-rest-framework/.venv/lib64/python3.12/site-packages/pluggy/_callers.py", 
line 113, in _multicall
INTERNALERROR>     raise exception.with_traceback(exception.__traceback__)
INTERNALERROR>   File "/home/markom-dot/research/django-rest-framework/.venv/lib64/python3.12/site-packages/pluggy/_callers.py", 
line 77, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>           ^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/home/markom-dot/research/django-rest-framework/tests/conftest.py", line 95, in pytest_configure
INTERNALERROR>     django.setup()
INTERNALERROR>   File "/home/markom-dot/research/django-rest-framework/.venv/lib64/python3.12/site-packages/django/__init__.py", 
line 24, in setup
INTERNALERROR>     apps.populate(settings.INSTALLED_APPS)
INTERNALERROR>   File "/home/markom-dot/research/django-rest-framework/.venv/lib64/python3.12/site-packages/django/apps/registry.
py", line 91, in populate
INTERNALERROR>     app_config = AppConfig.create(entry)
INTERNALERROR>                  ^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/home/markom-dot/research/django-rest-framework/.venv/lib64/python3.12/site-packages/django/apps/config.py
", line 193, in create
INTERNALERROR>     import_module(entry)
INTERNALERROR>   File "/usr/lib64/python3.12/importlib/__init__.py", line 90, in import_module
INTERNALERROR>     return _bootstrap._gcd_import(name[level:], package, level)
INTERNALERROR>            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "<frozen importlib._bootstrap>", line 1381, in _gcd_import
INTERNALERROR>   File "<frozen importlib._bootstrap>", line 1354, in _find_and_load
INTERNALERROR>   File "<frozen importlib._bootstrap>", line 1325, in _find_and_load_unlocked
INTERNALERROR>   File "<frozen importlib._bootstrap>", line 929, in _load_unlocked
INTERNALERROR>   File "<frozen importlib._bootstrap_external>", line 994, in exec_module
INTERNALERROR>   File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
INTERNALERROR>   File "/home/markom-dot/research/django-rest-framework/tests/importable/__init__.py", line 6, in <module>
INTERNALERROR>     from rest_framework import compat, serializers  # noqa
INTERNALERROR>     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/home/markom-dot/research/django-rest-framework/rest_framework/compat.py", line 64, in <module>
INTERNALERROR>     import markdown
INTERNALERROR>   File "/home/markom-dot/research/django-rest-framework/.venv/lib64/python3.12/site-packages/markdown/__init__.py"
, line 29, in <module>
INTERNALERROR>     from .core import Markdown, markdown, markdownFromFile  # noqa: E402
INTERNALERROR>     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/home/markom-dot/research/django-rest-framework/.venv/lib64/python3.12/site-packages/markdown/core.py", li
ne 26, in <module>
INTERNALERROR>     from . import util
INTERNALERROR>   File "/home/markom-dot/research/django-rest-framework/.venv/lib64/python3.12/site-packages/markdown/util.py", li
ne 86, in <module>
INTERNALERROR>     INSTALLED_EXTENSIONS = metadata.entry_points().get('markdown.extensions', ())
INTERNALERROR>                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR> AttributeError: 'EntryPoints' object has no attribute 'get'

Inside compat.py I've the following workaround. I just catch the AttributeError since Markdown is optional and not needed. I can successfully run tests by executing ./runtests.py.

except (ImportError, AttributeError):
    apply_markdown = None
    markdown = None

However, flake8 fails and I cannot commit this code of course. Here is the traceback:

flake8...................................................................Failed
- hook id: flake8
- exit code: 1

Traceback (most recent call last):
  File "/home/markom-dot/.cache/pre-commit/repoyalztujj/py_env-python3/bin/flake8", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/markom-dot/.cache/pre-commit/repoyalztujj/py_env-python3/lib/python3.12/site-packages/flake8/main/cli.py", line 22, in main
    app.run(argv)
  File "/home/markom-dot/.cache/pre-commit/repoyalztujj/py_env-python3/lib/python3.12/site-packages/flake8/main/application.py", line 363, in run
    self._run(argv)
  File "/home/markom-dot/.cache/pre-commit/repoyalztujj/py_env-python3/lib/python3.12/site-packages/flake8/main/application.py", line 350, in _run
    self.initialize(argv)
  File "/home/markom-dot/.cache/pre-commit/repoyalztujj/py_env-python3/lib/python3.12/site-packages/flake8/main/application.py", line 330, in initialize
    self.find_plugins(config_finder)
  File "/home/markom-dot/.cache/pre-commit/repoyalztujj/py_env-python3/lib/python3.12/site-packages/flake8/main/application.py", line 153, in find_plugins
    self.check_plugins = plugin_manager.Checkers(local_plugins.extension)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/markom-dot/.cache/pre-commit/repoyalztujj/py_env-python3/lib/python3.12/site-packages/flake8/plugins/manager.py", line 356, in __init__
    self.manager = PluginManager(
                   ^^^^^^^^^^^^^^
  File "/home/markom-dot/.cache/pre-commit/repoyalztujj/py_env-python3/lib/python3.12/site-packages/flake8/plugins/manager.py", line 238, in __init__
    self._load_entrypoint_plugins()
  File "/home/markom-dot/.cache/pre-commit/repoyalztujj/py_env-python3/lib/python3.12/site-packages/flake8/plugins/manager.py", line 254, in _load_entrypoint_plugins
    eps = importlib_metadata.entry_points().get(self.namespace, ())
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'EntryPoints' object has no attribute 'get'

MarkoM-dot · 2023-11-26T23:29:23Z

I have submitted a pr here: #9167

Hope this helps!

into py312

tox.ini

auvipy · 2023-12-06T17:02:21Z

=========================== short test summary info ============================
ERROR tests/test_fields.py - ValueError: not enough values to unpack (expecte...
ERROR tests/schemas/test_coreapi.py - ValueError: not enough values to unpack...
ERROR tests/schemas/test_openapi.py - ValueError: not enough values to unpack...
!!!!!!!!!!!!!!!!!!! Interrupted: 3 errors during collection !!!!!!!!!!!!!!!!!!!!
======================== 2 warnings, 3 errors in 9.72s =========================

kiendang · 2023-12-14T10:42:35Z

=========================== short test summary info ============================ ERROR tests/test_fields.py - ValueError: not enough values to unpack (expecte... ERROR tests/schemas/test_coreapi.py - ValueError: not enough values to unpack... ERROR tests/schemas/test_openapi.py - ValueError: not enough values to unpack... !!!!!!!!!!!!!!!!!!! Interrupted: 3 errors during collection !!!!!!!!!!!!!!!!!!!! ======================== 2 warnings, 3 errors in 9.72s =========================

@auvipy #9180 should fix this.

auvipy · 2023-12-14T10:44:34Z

OK let me check

kiendang · 2023-12-14T10:46:45Z

This part in #9180 needs to be changed though. The issue is with djangomain, not 5.0.

if django.VERSION >= (5, 0):

kiendang · 2023-12-14T11:09:46Z

This part in #9180 needs to be changed though. The issue is with djangomain, not 5.0.
if django.VERSION >= (5, 0):

This is now rectified in the PR (if django.VERSION >= (5, 1)...).

tomchristie · 2024-01-04T14:14:12Z

ready for review?

tomchristie · 2024-01-04T14:47:53Z

tox.ini

 [testenv:py311-djangomain]
 ignore_outcome = true
+[testenv:py312-djangomain]
+ignore_outcome = true


Suggested change

[testenv:py311-djangomain]

ignore_outcome = true

[testenv:py312-djangomain]

ignore_outcome = true

[testenv:py311-djangomain]

ignore_outcome = true

[testenv:py312-djangomain]

ignore_outcome = true

kiendang · 2024-01-19T04:14:55Z

@auvipy Tests for 3.12 should pass now if you merge with master.

tox.ini

math-a3k · 2024-01-24T01:00:06Z

@auvipy you can cherry-pick the last two commits in #9230 which fixes the pre-commit error and enables coreapi tests for python 3.12 - after rebasing with master it should all be working as expected (not considering djangomain)

auvipy · 2024-02-20T13:12:37Z

thanks Rodrigo

math-a3k · 2024-02-22T00:32:19Z

🙏

auvipy · 2024-02-22T10:38:09Z

🙏

just wanted to make sure you also get some credit

auvipy added 2 commits November 5, 2023 11:25

added python 3.12 to CI

30c61d7

Merge branch 'master' of https://github.com/encode/django-rest-framework

9b0b130

into py312

MarkoM-dot mentioned this pull request Nov 26, 2023

fix(compat): catch AttributeError since EntryPoints object has no get() #9167

Closed

Merge branch 'master' of https://github.com/encode/django-rest-framework

df891a9

into py312

auvipy commented Dec 6, 2023

View reviewed changes

tox.ini Show resolved Hide resolved

Update tox.ini

f890bd4

tomchristie reviewed Jan 4, 2024

View reviewed changes

tomchristie mentioned this pull request Jan 4, 2024

3.15 Release #9210

Merged

auvipy commented Jan 19, 2024

View reviewed changes

tox.ini Show resolved Hide resolved

Update tox.ini

d708adb

math-a3k mentioned this pull request Jan 20, 2024

Add Python 3.12 support #9230

Merged

Update tox.ini

7540885

auvipy marked this pull request as ready for review February 20, 2024 13:06

auvipy merged commit 336e7ad into encode:master Feb 20, 2024
9 checks passed

auvipy deleted the py312 branch February 20, 2024 13:12

auvipy added this to the 3.15 milestone Feb 20, 2024

tomchristie mentioned this pull request Jun 14, 2024

Version 3.15.2. #9439

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added python 3.12 to CI #9157

added python 3.12 to CI #9157

auvipy commented Nov 5, 2023 •

edited

Loading

MarkoM-dot commented Nov 26, 2023 •

edited

Loading

MarkoM-dot commented Nov 26, 2023

auvipy commented Dec 6, 2023

kiendang commented Dec 14, 2023

auvipy commented Dec 14, 2023

kiendang commented Dec 14, 2023

kiendang commented Dec 14, 2023

tomchristie commented Jan 4, 2024

tomchristie Jan 4, 2024

kiendang commented Jan 19, 2024

math-a3k commented Jan 24, 2024

auvipy commented Feb 20, 2024

math-a3k commented Feb 22, 2024

auvipy commented Feb 22, 2024

added python 3.12 to CI #9157

added python 3.12 to CI #9157

Conversation

auvipy commented Nov 5, 2023 • edited Loading

MarkoM-dot commented Nov 26, 2023 • edited Loading

MarkoM-dot commented Nov 26, 2023

auvipy commented Dec 6, 2023

kiendang commented Dec 14, 2023

auvipy commented Dec 14, 2023

kiendang commented Dec 14, 2023

kiendang commented Dec 14, 2023

tomchristie commented Jan 4, 2024

tomchristie Jan 4, 2024

Choose a reason for hiding this comment

kiendang commented Jan 19, 2024

math-a3k commented Jan 24, 2024

auvipy commented Feb 20, 2024

math-a3k commented Feb 22, 2024

auvipy commented Feb 22, 2024

auvipy commented Nov 5, 2023 •

edited

Loading

MarkoM-dot commented Nov 26, 2023 •

edited

Loading