Reapply "In MODULARIZE mode avoid modifying the incoming moduleArg. (#21775)" #22826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FC (emscripten-core#21775)" This change was reverted in emscripten-core#21994 because the file_packager generated code expected to be able to use propertied on the Module object that was passed to the constructor/factor function. However that issue was fixed in emscripten-core#22086 so we can try to land this once again.
kripken
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was reverted in #21994 because the file_packager generated code expected to be able to use propertied on the Module object that was passed to the constructor/factor function. However that issue was fixed in #22086 so we can try to land this once again.