Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file_packager.py: Fix runWithFS() to use passed-in Module (issue since PR #21775) #22086

Merged
merged 1 commit into from
Jun 11, 2024
Merged

file_packager.py: Fix runWithFS() to use passed-in Module (issue since PR #21775) #22086

merged 1 commit into from
Jun 11, 2024

Conversation

past-due
Copy link
Contributor

Fixes: #22085

callRuntimeCallbacks passes the actual Module, so use it

@past-due
file_packager.py: Fix runWithFS() since PR emscripten-core#21775
9af3328 
callRuntimeCallbacks passes the actual Module, so use it
@past-due past-due mentioned this pull request Jun 11, 2024
Closed
@past-due past-due marked this pull request as draft June 11, 2024 02:23
sbc100
sbc100 approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to mark this a non-draft?

@past-due past-due marked this pull request as ready for review June 11, 2024 19:52
@past-due
Copy link
Contributor Author

Do you want to mark this a non-draft?

Done 👍

@sbc100 sbc100 merged commit 0086fa3 into emscripten-core:main Jun 11, 2024
29 checks passed
@dschuff dschuff mentioned this pull request Oct 29, 2024
Merged
sbc100 added a commit to sbc100/emscripten that referenced this pull request Nov 1, 2024
@sbc100
Reapply "In MODULARIZE mode avoid modifying the incoming moduleArg. N…
a751c39 
…FC (emscripten-core#21775)"

This change was reverted in emscripten-core#21994 because the file_packager generated
code expected to be able to use propertied on the Module object that
was passed to the constructor/factor function.  However that issue was
fixed in emscripten-core#22086 so we can try to land this once again.
@sbc100 sbc100 mentioned this pull request Nov 1, 2024
Open
@dschuff dschuff mentioned this pull request Nov 15, 2024
Merged
sbc100 added a commit to sbc100/emscripten that referenced this pull request Jan 2, 2025
@sbc100
Reapply "In MODULARIZE mode avoid modifying the incoming moduleArg. N…
c94f916 
…FC (emscripten-core#21775)"

This change was reverted in emscripten-core#21994 because the file_packager generated
code expected to be able to use propertied on the Module object that
was passed to the constructor/factor function.  However that issue was
fixed in emscripten-core#22086 so we can try to land this once again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Since PR #21775, additional file packages error on load in modularize build when registered for preRun
2 participants
@past-due @sbc100