About page #60
About page #60
Conversation
- Needs actual text
[x] Removed unused background sass file
[x] Moved nav inside container
|
Footer is broken, but this needs to be fixed separately. |
webpack/components/Layout.jsx
Outdated
| @@ -13,14 +13,15 @@ export default class Layout extends React.Component { | |||
| render() { | |||
| return ( | |||
| <div className="page-wrap"> | |||
| <Nav /> | |||
There was a problem hiding this comment.
This will be addressed in the pull request for #10. Can it be removed from this pull request pretty please?
webpack/components/Nav.jsx
Outdated
| @@ -13,7 +13,7 @@ export default class Nav extends React.Component { | |||
| }); | |||
|
|
|||
| return ( | |||
| <nav className="navbar navbar-fixed-top"> | |||
| <nav className="navbar navbar-default"> | |||
There was a problem hiding this comment.
This will be addressed in the pull request for #10. Can it be removed from this pull request pretty please?
| @@ -1,4 +1,8 @@ | |||
| --- | |||
| # These lines are for Jekyll | |||
There was a problem hiding this comment.
Why are these lines needed?
There was a problem hiding this comment.
The 6 dashes are a Jekyll thing, so Jekyll knows it's has to do something with the file.
src/_sass/_images.scss
Outdated
| background-position: top center; | ||
| background-repeat: no-repeat; | ||
| background-size: cover; | ||
| background-color: #fff; |
There was a problem hiding this comment.
If we are having a background image covering the whole view, is this background-color needed?
There was a problem hiding this comment.
Removed in latest commit.
| @@ -0,0 +1,6 @@ | |||
| @mixin background-size($size) { | |||
There was a problem hiding this comment.
Now being used in latest commit.
webpack/components/pages/About.jsx
Outdated
| <div className="pt-5"> | ||
| <PageHeader>{ about.title }</PageHeader> | ||
| <p>{ about.lorem }</p> | ||
|
|
There was a problem hiding this comment.
Removed in latest commit.
- Removed blank line in About.jsx - Used the background-size mixin
|
All good this end (once the conflict has been resolved) 😸 |
Addresses issue: #18
What this does
Screenshots