-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#49] Coming Soon page #59
Conversation
Import { DMLButton } from … will only work if DMLButton contains a *named export* called A: http://stackoverflow.com/a/36796281/6046659
|
||
render() { | ||
return ( | ||
<div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use a button
rather than a div
?
@tanyapowell changes look good and fine on mobile to me too. Not sure if you saw Rocio's update to the UX of this page in #48 (comment). Basically, the background image has changed and a couple of styles + link to EmpowerHack with logo. Feel free to merge this and we can do the updates in a separate ticket, or as part of this ticket. Either way! |
@rocioleon @tanyapowell Updated with UX close to the changes in #48 (comment). To keep code simple and get this out quick with my rusty CSS skills, not as much variation for small & medium viewports as the mockups have but it works responsively fine. Also had to guess with some colours (and image opacity etc) using styleguide. @rocioleon One thing I need is an asset for the logo with white text, as could only find the dark text version in the Drive. I'm going to merge this now in any case and get it up on GitHub pages, any other changes (and quick update of logo) can be done in a separate PR. |
Addresses issue: #49
What this does
Screenshots
Desktop:
Tablet:
Phone: