Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#49] Coming Soon page #59

Merged
merged 7 commits into from
May 14, 2017
Merged

[#49] Coming Soon page #59

merged 7 commits into from
May 14, 2017

Conversation

krissy
Copy link
Member

@krissy krissy commented Apr 17, 2017

Addresses issue: #49

What this does

Screenshots

Desktop:

dml_site_large

Tablet:

dml_site_medium

Phone:

dml_site_small

Import { DMLButton } from … will only work if DMLButton contains a *named export* called A:
http://stackoverflow.com/a/36796281/6046659

render() {
return (
<div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use a button rather than a div?

@tanyapowell
Copy link
Member

Currently blocked by #60 and the lack of responsive designs ( #48 ). Once #60 and #61 have been merged will revisit this to tidy up the sass architecture

Desktop version

image

@krissy
Copy link
Member Author

krissy commented May 7, 2017

@tanyapowell changes look good and fine on mobile to me too. Not sure if you saw Rocio's update to the UX of this page in #48 (comment). Basically, the background image has changed and a couple of styles + link to EmpowerHack with logo. Feel free to merge this and we can do the updates in a separate ticket, or as part of this ticket. Either way!

@tanyapowell
Copy link
Member

Cool @krissy. If I have time tonight I'll finish it off with the new designs, if I don't manage to do it by tomorrow night (May 13th) then someone else please feel free to pick it up.

Also, #60 is no longer blocking this. So I've removed blocked status as there are no longer any impediments

@krissy
Copy link
Member Author

krissy commented May 14, 2017

@rocioleon @tanyapowell Updated with UX close to the changes in #48 (comment). To keep code simple and get this out quick with my rusty CSS skills, not as much variation for small & medium viewports as the mockups have but it works responsively fine. Also had to guess with some colours (and image opacity etc) using styleguide.

@rocioleon One thing I need is an asset for the logo with white text, as could only find the dark text version in the Drive.

I'm going to merge this now in any case and get it up on GitHub pages, any other changes (and quick update of logo) can be done in a separate PR.

@krissy krissy merged commit 9741ca1 into master May 14, 2017
@krissy krissy deleted the 49/coming-soon branch May 14, 2017 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants