Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrated to null safety #26 #27

Merged
merged 3 commits into from
Mar 16, 2021
Merged

migrated to null safety #26 #27

merged 3 commits into from
Mar 16, 2021

Conversation

pr-1
Copy link
Contributor

@pr-1 pr-1 commented Mar 7, 2021

Hi @emostar I have migrated this to null safety using the dart tool. Please have a look and see if it needs any changes ?

@bhavin-concetto
Copy link
Contributor

bhavin-concetto commented Mar 9, 2021

@pr-1 you need to update dart version too as I have tried using your PR. I have created new PR#1 Please accept it.

Commit for Null Safety and update dart sdk 2.12.0
@pr-1
Copy link
Contributor Author

pr-1 commented Mar 9, 2021

Thanks @bhavin-concetto

@bhavin-concetto
Copy link
Contributor

@emostar can you merge this PR?

@cedvdb
Copy link

cedvdb commented Mar 15, 2021

it might be useful to add more maintainers to the project too

@emostar
Copy link
Owner

emostar commented Mar 16, 2021

@pr-1 Thank you very much for your contribution!

@cedvdb I'm more than willing to add more maintainers, just need someone to say they will.

@emostar emostar merged commit 06a5d82 into emostar:master Mar 16, 2021
@pr-1
Copy link
Contributor Author

pr-1 commented Mar 16, 2021

You can add me if you want @emostar and can you release the package now to pub so that i can start working on updating other packages that depend on this one.

@emostar
Copy link
Owner

emostar commented Mar 16, 2021

@pr-1 Alright, I'll add you. I just published it to pub as 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants