-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fullscreen #674
Fullscreen #674
Conversation
The default state can be set with the `NativeOptions` at compile time, and can be changed by using a callback to the UI context during runtime. The fullscreen state is written to the RON file so that the user-set state is restored on each launch. I added a 'toggle fullscreen' button to the UI too, so that can be previewed.
Thanks for the PR!
See #672 for how something similar was implemented. |
Got it, sorry I didn’t see that second comment you made on the issue, but I'll see what I can do about moving that around :) |
added logic to restore previous window size when exiting fullscreen
I got really busy with school stuff and work for several weeks, but finally winding down. I moved those changes around. It was a little tricky to deal with the AppOutput resetting itself every frame; that would undo whatever state was set in the previous frame. I pulled it out to give it slightly broader scope, and I didn't notice any problems it caused. |
Yeah, it is in need of a refactor. |
Any interest in this still? |
@emilk Yes! Is there any way I can help get this merged? |
@antouhou Since a lot in this PR is outdated (a lot of epi/eframe refactor), I'm guessing your best bet it so create a new PR from scratch, perhaps with some inspiration taken from this one. |
Closes #674 Adds `NativeOptions:fullscreen`, `Frame::set_fullscreen` and `WindowInfo::fullscreen`.
The default state can be set with the
NativeOptions
at compile time, and can be changed by using a callback to the UI context during runtime. The fullscreen state is written to the RON file so that the user-set state is restored on each launch.I added a 'toggle fullscreen' button to the UI too, so that can be previewed.
Closes #662.