feat: Set whether to show decorations #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
requested changes
Aug 27, 2021
emilk
added a commit
that referenced
this pull request
Aug 28, 2021
|
I reverted the merge, because this PR removed decorations by default, at least on my mac. Not good! I should have tested it first 🤦 |
|
Sorry for that, it's my fault, I will relaunch a PR. |
zu1k
added a commit
to zu1k/egui
that referenced
this pull request
Aug 28, 2021
* feat: Set whether to show decorations * cargo fmt * Update comment and changelog
zu1k
pushed a commit
to zu1k/egui
that referenced
this pull request
Aug 28, 2021
mankinskin
pushed a commit
to mankinskin/egui
that referenced
this pull request
Sep 29, 2021
* feat: Set whether to show decorations * cargo fmt * Update comment and changelog
mankinskin
pushed a commit
to mankinskin/egui
that referenced
this pull request
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set whether to show decorations when update frame.
I have tested it on my project: https://github.com/zu1k/copy-translator/blob/6eca80ca32593f2d55eda0fc950e1f1ff0cd52eb/src/ui.rs#L252