Add x11 and wayland features to egui-wgpu and egui_glow
#3909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winit does not build otherwise.
It does not seem to be needed in this case.
emilk
reviewed
Jan 29, 2024
Comment on lines
+34
to
+42
| ## Enable [`winit`](https://docs.rs/winit) integration. On Linux, requires either `wayland` or `x11` | ||
| winit = ["dep:winit"] | ||
|
|
||
| ## Enables Wayland support for winit. | ||
| wayland = ["winit?/wayland"] | ||
|
|
||
| ## Enables x11 support for winit. | ||
| x11 = ["winit?/x11"] | ||
|
|
There was a problem hiding this comment.
If a user is using egui-wgpu with the winit feature, they are also depending directly on winit, and can set the x11/wayland features themselves, no?
There was a problem hiding this comment.
Yes, but then you have to think about that when running cargo check, cargo doc etc, which is the problem noted in the issues. Technically you don't have to enable these features in a real project, they just help make the repo more ergonomic to work with. I don't know if there is a better solution.
There was a problem hiding this comment.
The problem would still happen with cargo check though, just not with cargo check --all-features ?
emilk
approved these changes
Jan 30, 2024
emilk
changed the title
x11 and wayland features to egui-wgpu and egui_glow
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows them to build correctly on Linux by passing one or both of the features alongside
winit.Closes #3492
Closes #2286