Enable winit backends when building egui-wgpu on docs.rs to fix failures #3907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe egui-wgpu should have the "x11" and "wayland" features like egui-winit and eframe do? Would that make sense? |
|
egui_glow has the same problem, by the way. |
|
I opened #3909 to try and solve the issue more broadly, if anyone wants to take a look. |
I'm not sure it makes sense if the user will need to separately depend on winit. I assume that this is the case here but I haven't looked very deeply into it. |
emilk
approved these changes
Jan 29, 2024
emilk
added
docs and examples
|
I believe this is no longer needed since #3909 merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested that this command fails:
And that this one, which I think will correspond to these changes, succeeds:
#3492 should be fixed by this
Also, I noticed that the PR template and
CONTRIBUTING.mdmention running./scripts/check.shwhich in a few cases has the same issue of winit failing to build with no backends enabled. I guess this script hasn't been in use?