Mypy for intervals #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AVHopp
requested changes
Dec 11, 2023
AVHopp
approved these changes
Dec 14, 2023
Scienfitz
reviewed
Dec 15, 2023
Unfortunately, forward refs seem not yet supported for singledispatch: https://bugs.python.org/issue41987
AdrianSosic
force-pushed
the
mypy/interval
branch
from
ebd19ee to
bbe039c
Compare
Scienfitz
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables
mypyfor theIntervalclass, which are used by targets (done in #54) and parameters (done in #28). Along the way, adds missing type hints and cleans up the class properties.In particular, replaces the somewhat misleading
is_finiteandis_boundedmethods with the common and easy-to-understand mathematical definitionsis_open,is_half_openandis_closed, ensuring backward compatibility via deprecation mechanisms.@AVHopp , @Scienfitz: Note that the PR builds upon #54, in order to configure the right diff view.