Mypy for targets #54
Merged
Mypy for targets #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianSosic
force-pushed
the
mypy/targets
branch
from
33472f6 to
330163c
Compare
Merged
AVHopp
requested changes
Dec 11, 2023
Scienfitz
reviewed
Dec 13, 2023
AdrianSosic
force-pushed
the
mypy/targets
branch
from
330163c to
9fc3952
Compare
Scienfitz
approved these changes
Dec 15, 2023
AVHopp
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables
mypyfor the targets package (hence resolves #27) and fixes attributes along the way.Most notably, renames
bounds_transform_functarget attribute totransform_modeand renames/moves the corresponding transform utilities for better code structure. Reason is thatbounds_transform_funcis misleading in two ways: the transforms are not really related to the bounds (they only use them) and the attribute doesn't refer to a callable but really to a transform "mode".@AVHopp, @Scienfitz: The PR builds upon the existing #6 PR, so when looking at the diffs, make sure to select the correct base commit (in contrast to Azure, Github in fact offers this functionality 🥇)