[CLEANUP] Remove all traces of named outlets code #20570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus dropping support for an old version of ember-test-helpers, apparently.
The split definitions between the rendering and routing layer was because the rendering layer was the first package to be converted into TypeScript. Now that everything is converted they should be sharing the same definition of the interface.
chancancode
force-pushed
the
named-outlets-removal
branch
from
b0c8459 to
7f388fd
Compare
| @@ -120,16 +117,9 @@ function stateFor(ref: Reference, outlet: OutletState | undefined): OutletDefini | |||
| let template = render.template; | |||
| if (template === undefined) return null; | |||
|
|
|||
| // this guard can be removed once @ember/test-helpers@1.6.0 has "aged out" | |||
| // And interface reflects that. Now that this is not supported anymore, each | ||
| // route implicitly renders into its immediate parent's `{{outlet}}` (no name). | ||
| // Keeping around most of these to their appropriately hardcoded values for the | ||
| // time being to minimize churn for external consumers, as we are about to rip |
| * Has to do with render helper and orphan outlets. | ||
| * Whether outlet state was rendered. | ||
| * @deprecated | ||
| * |
There was a problem hiding this comment.
I really appreciate all these comments -- as someone who is just learning how the glue fits together, this is immensely helpful for provided much needed context as well as a bit of why
NullVoxPopuli
approved these changes
Nov 9, 2023
kategengler
approved these changes
Nov 9, 2023
wagenet
approved these changes
Nov 9, 2023
chancancode
added a commit
to emberjs/ember-test-helpers
that referenced
this pull request
Nov 18, 2023
The canary build started failing after emberjs/ember.js#20570 was merged. We were never supposed to pass a `TemplateFactory` to `OutletState`, but it was previously tolerated. The pattern was fixed in the pass, but regressed when implementing support for `render(<template>...</template>)`.
chancancode
added a commit
that referenced
this pull request
Nov 22, 2024
The actual behavior change was marked with an intimate deprecation and has aged out. The actual versions of ember-test-helpers affected seems to be around <= 3.2.0, which should be fully absorbed by now. The other changes to `OutletState` doesn't actually change behavior, those fields were mostly just kept around assuming we are keeping this code frozen and to be deleted soon, so they documented what those were on the off chance that someone came into look. Now that it looks like this code may be here to stay for a bit longer, it's worth cleaning it up to make things less confusing for core devs. Follow-up to #20570
chancancode
added a commit
that referenced
this pull request
Nov 22, 2024
The actual behavior change was marked with an intimate deprecation and has aged out. The actual versions of ember-test-helpers affected seems to be around <= 3.2.0, which should be fully absorbed by now. The other changes to `OutletState` doesn't actually change behavior, those fields were mostly just kept around assuming we are keeping this code frozen and to be deleted soon, so they documented what those were on the off chance that someone came into look. Now that it looks like this code may be here to stay for a bit longer, it's worth cleaning it up to make things less confusing for core devs. Follow-up to #20570
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a lot of code that were needed for supporting named outlets, it seems like we never fully cleaned it up.