Fix ember-canary error/deprecation #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The canary build started failing after emberjs/ember.js#20570 was merged. We were never supposed to pass a `TemplateFactory` to `OutletState`, but it was previously tolerated. The pattern was fixed in the pass, but regressed when implementing support for `render(<template>...</template>)`.
chancancode
added a commit
to emberjs/ember.js
that referenced
this pull request
Nov 18, 2023
Fixes #20576 The test is a bit misleading in that, this is not actually restored to support the very old 1.6.0 version of ember-test-helpers. The issue is that while that particular spot of the invalid usage was fixed in 1.6.1, other similarly invalid patterns have popped up in the code since then. However, the old tests was probably a close enough approximation of the general problem. This is not to avoid fixing the actual issue, but it's just that it was very difficult for us to support for a short time, and there may be other code that copied the same invalid pattern elsewhere. See also emberjs/ember-test-helpers#1445
chancancode
added a commit
to emberjs/ember.js
that referenced
this pull request
Nov 18, 2023
Fixes #20576 The test is a bit misleading in that, this is not actually restored to support the very old 1.6.0 version of ember-test-helpers. The issue is that while that particular spot of the invalid usage was fixed in 1.6.1, other similarly invalid patterns have popped up in the code since then. However, the old tests was probably a close enough approximation of the general problem. This is not to avoid fixing the actual issue, but it's just that it was very difficult for us to support for a short time, and there may be other code that copied the same invalid pattern elsewhere. See also emberjs/ember-test-helpers#1445
chancancode
added a commit
to emberjs/ember.js
that referenced
this pull request
Nov 18, 2023
Fixes #20576 The test is a bit misleading in that, this is not actually restored to support the very old 1.6.0 version of ember-test-helpers. The issue is that while that particular spot of the invalid usage was fixed in 1.6.1, other similarly invalid patterns have popped up in the code since then. However, the old tests was probably a close enough approximation of the general problem. This is not to avoid fixing the actual issue, but it's just that it was very difficult for us to support for a short time, and there may be other code that copied the same invalid pattern elsewhere. See also emberjs/ember-test-helpers#1445
NullVoxPopuli
approved these changes
Nov 18, 2023
|
https://github.com/emberjs/ember-test-helpers/actions/runs/6911462222/job/18809097106 – it did trigger the deprecation (as intended) but we didn't set it to raise on deprecation |
chancancode
added a commit
to chancancode/discourse
that referenced
this pull request
Dec 14, 2023
Mainly we are after emberjs/ember-test-helpers#1445 so the Ember 5 test suite doesn't fail on canary, but also took some code from emberjs/ember-test-helpers#1378 as needed to make the code make sense.
davidtaylorhq
pushed a commit
to discourse/discourse
that referenced
this pull request
Jan 3, 2024
Mainly we are after emberjs/ember-test-helpers#1445 so the Ember 5 test suite doesn't fail on canary, but also took some code from emberjs/ember-test-helpers#1378 as needed to make the code make sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The canary build started failing after emberjs/ember.js#20570 was merged. We were never supposed to pass a
TemplateFactorytoOutletState, but it was previously tolerated. The pattern was fixed in the pass, but regressed when implementing support forrender(<template>...</template>).No new tests because existing ones are already failing. If we wait till emberjs/ember.js#20577 lands then we should see it turn into a deprecation, and this fix will remove the deprecation.