Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE set-component-template] Add @ember/component/template-only #18190

Merged
merged 1 commit into from
Jul 11, 2019
Merged

[FEATURE set-component-template] Add @ember/component/template-only #18190

merged 1 commit into from
Jul 11, 2019

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jul 11, 2019

As part of emberjs/rfcs#481 this adds the @ember/component/template-only module, and its associated implementation.

@kategengler kategengler mentioned this pull request Jul 11, 2019
Closed
15 tasks
@rwjblue
Copy link
Member Author

rwjblue commented Jul 11, 2019

Updated to fix linting error.

@rwjblue
Copy link
Member Author

rwjblue commented Jul 11, 2019

@chancancode - Updated to use the passed in moduleName for the toString. Also did an initial pass at API docs for the new method.

@rwjblue rwjblue requested a review from chancancode July 11, 2019 14:05
@chancancode @rwjblue
[FEATURE set-component-template] Add @ember/component/template-only
b53699e 
As part of RFC 481 this adds the `@ember/component/template-only` module, and
its associated implementation.

Co-authored-by: Robert Jackson <me@rwjblue.com>
@rwjblue rwjblue merged commit 4a0d8cb into master Jul 11, 2019
@rwjblue rwjblue deleted the template-only branch July 11, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chancancode chancancode Awaiting requested review from chancancode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwjblue @chancancode