Refactor template factory #18096
Refactor template factory #18096
Conversation
wycats
force-pushed
the
refactor-template-factory
branch
from
83cbc0e
to
5ece62b
Compare
|
Failed on linting: Need to fix this one manually I think. |
rwjblue
force-pushed
the
refactor-template-factory
branch
from
5ece62b
to
4418283
Compare
|
I just rebased and fixed the linting failure. @pzuraq / @krisselden - I'd love review here when y'all have a minute. |
rwjblue
force-pushed
the
refactor-template-factory
branch
from
4418283
to
3bbc08d
Compare
Per RFC #481, we want to align the factory signature between templates and component managers. Since the factories for component managers are just a function that takes the owner, we decided to move template factories in the same direction here as well. Co-authored-by: Robert Jackson <me@rwjblue.com>
|
CI is green now, still needs some review though... Ping again @krisselden / @pzuraq 😸 |
| registry.register('view:-outlet', OutletView); | ||
| registry.register('template:-outlet', OutletTemplate); | ||
| registry.register('template:-outlet', OutletTemplate as any); |
There was a problem hiding this comment.
why does this need as any?
| { | ||
| componentDefinitionCount: 1, | ||
| // 1 from this.render, 1 from component-one | ||
| templateCacheMisses: 2, |
There was a problem hiding this comment.
prior to this change, this path was only used for late bound templates that were cached because their lifetime wasn't in the DI system's container.
There was a problem hiding this comment.
Yep, thats correct. Are you saying this is bad/wrong/etc?
emberjs/ember.js#18096 This PR changed how templates get transpiled under the hood. The export from templates are now factory functions which expect to be passed the `owner`.
emberjs/ember.js#18096 This PR changed how templates are used under the hood. Template modules now export a factory function that expects to be called with the `owner`.
|
if (DEBUG) {
let owner = getOwner(this);
let template = definition.template(owner);
this._pushToDebugStack(`template:${template.referrer.moduleName}`, environment);
}Or should this class actually still be instantiated with an |
emberjs/ember.js#18096 This PR changed how templates are used under the hood. Template modules now export a factory function that expects to be called with the `owner`.
|
Example of a test suite failure: https://travis-ci.org/salsify/ember-css-modules/jobs/552819509 |
|
|
|
@rwjblue Thanks for the pointer! I submitted a PR: emberjs/ember-test-helpers#677 |
|
#18168 should fix the specific issue that @buschtoens ran into (without necessarily coupling it to an |
emberjs/ember.js#18096 This PR changed how templates get transpiled under the hood. The export from templates are now factory functions which expect to be passed the `owner`.
Per RFC #481, we want to align the factory signature between templates and component managers. Since the factories for component managers are just a function that takes the owner, we decided to move template factories in the same direction here as well.