[DEPRECATION] deprecate Component#isVisible

[GavinJoyce]

part of #17918

TODO:

• Update the deprecation message to include the component's toString
• Add svelting for the new deprecation
• Update documentation to mark isVisible as @deprecated
• Deprecation guide PR: Deprecate Component#isVisible ember-learn/deprecation-app#451

[rwjblue]

Looking good! I left some minor inline comments for tweaks, but we also need to flag this for svelting.

The rough steps for svelting are:

• Add a new export from packages/@ember/deprecated-features/index.js, the string value should be 3.11.0-beta.1 (which will be the first tagged release including the deprecation)
• Import that boolean flag and surround any code supporting isVisible with a conditional (e.g. if (EMBER_COMPONENT_IS_VISIBLE) { /* code here */ })

Some example PRs adding svelting as part of a deprecation:

• [DEPRECATION] Add deprecation for Function.prototype extensions. #17910
• [DEPRECATE] Deprecates aliasMethod #17540
• Wrap all existing deprecated features for svelting. #16685

The goal here is that any code that is supporting a deprecated feature will (eventually) be able to be stripped from apps that declare that they are "deprecation free" for a given version.

[rwjblue]

Oh, also noticed, we should update the docs for isVisible with @deprecated.

[rwjblue]

@GavinJoyce - Sorry for being spammy here, I updated the PR description with a checklist...

[rwjblue]

Looks really good, only one more small nit and I think we are good (once the deprecation guide lands).

[rwjblue]

any is a bit unfortunate here, can we make it:

export let IsVisibleBinding: undefined | {
  install(element: Simple.Element, component: Component, operations: ElementOperations): void;
};

(I think mapStyleValue is only used internally?)

[GavinJoyce]

Thanks, I've updated it to:

export let IsVisibleBinding: undefined | {
  install(element: Simple.Element, component: Component, operations: ElementOperations): void;
  mapStyleValue(isVisible: boolean, component: Component): SafeString | null;
};

With my currently limited knowledge of TS, I couldn't find a way to mark mapStyleValue as private.

[GavinJoyce]

@rwjblue thanks for all the feedback, that will help me a lot in future deprecations.

This and ember-learn/deprecation-app#451 are ready I believe

[rwjblue]

Two very minor nit-pick's, but otherwise this is good to go...

[rwjblue]

Sorry @GavinJoyce, looks like a prettier error in CI now:

$ eslint . --cache --ext=js,ts
/home/travis/build/emberjs/ember.js/packages/@ember/-internals/glimmer/lib/component-managers/curly.ts
  96:7  error  Replace `EMBER_COMPONENT_IS_VISIBLE·&&·IsVisibleBinding·!==·undefined·&&·seen.indexOf('style')·===·-1` with `⏎····EMBER_COMPONENT_IS_VISIBLE·&&⏎····IsVisibleBinding·!==·undefined·&&⏎····seen.indexOf('style')·===·-1⏎··`  prettier/prettier

[GavinJoyce]

sorry - updated, thanks