Wrap all existing deprecated features for svelting. #16685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
more-deprecation-flags
branch
from
1d0024a
to
3313226
Compare
bekzod
reviewed
May 25, 2018
| @@ -390,67 +391,75 @@ export class Meta { | |||
| } | |||
|
|
|||
| writeBindings(subkey: string, value: any) { | |||
There was a problem hiding this comment.
maybe conditionally extend meta like done here: #16355
There was a problem hiding this comment.
would you mind updating that PR to fix it up? I do agree that is nice
krisselden
approved these changes
May 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.