conditionally add bindings related methods to meta #16355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Mar 10, 2018
|
@rwjblue addons should get a chance to add to the env, I think module unification if I recall is pulling config too early and caching it, we should ensure the env does get baked until all addons been initialized. |
|
@krisselden - I completely agree with what you said, but it has no relationship to this PR (or my prior comment). |
bekzod
force-pushed
the
conditionally-bindings
branch
2 times, most recently
from
db261eb
to
7f6e102
Compare
bekzod
force-pushed
the
conditionally-bindings
branch
from
7f6e102
to
7e1afc3
Compare
|
@rwjblue this is updated with svelting flags |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENV._ENABLE_BINDING_SUPPORTis not enabled there is no need to have such methods inmeta?