[Backport] Add exception for didRemoveListener so evented proxy objects can
#16496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function
When `off` is called on an Evented proxyish object it checks to see if
didRemoveListener is a function (so that it can later call it). This
check triggers the assertion for proxy-ish objects to use `get` rather
than installed es5-getter so we add a special case to allow it.
Prior to this change when you called `off` on the proxyish object it
would trigger an assertion telling you to call
`eventedProxyObj.get('didRemoveListener') rather than
`eventedProxyObj.didRemoveListener`.
A few notes about this test:
- the unknownProperty is how we let ember know this is a proxy
- the unknownProperty function must return a value other than undefined
- Evented Mixin must be mixed in
rwjblue
approved these changes
Apr 11, 2018
|
Sorry for missing this, thanks for fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
offis called on an Evented proxyish object it checks to see ifdidRemoveListener is a function (so that it can later call it). This
check triggers the assertion for proxy-ish objects to use
getratherthan installed es5-getter so we add a special case to allow it.
Prior to this change when you called
offon the proxyish object itwould trigger an assertion telling you to call
eventedProxyObj.get('didRemoveListener') rather thaneventedProxyObj.didRemoveListener`.A few notes about this test: