Merge pull request #16496 from rondale-sc/backport-proxy-fix

[Backport] Add exception for `didRemoveListener` so evented proxy objects can
emberjs · Apr 11, 2018 · 50db6dc · 50db6dc
2 parents 7b2afbe + 45359b0
commit 50db6dc
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/packages/ember-runtime/lib/system/core_object.js b/packages/ember-runtime/lib/system/core_object.js
@@ -102,6 +102,7 @@ function makeCtor() {
               property === 'willWatchProperty' ||
               property === 'didUnwatchProperty' ||
               property === 'didAddListener' ||
+              property === 'didRemoveListener' ||
               property === '__DESCRIPTOR__' ||
               property === 'isDescriptor' ||
               property in target

diff --git a/packages/ember-runtime/tests/mixins/evented_test.js b/packages/ember-runtime/tests/mixins/evented_test.js
@@ -0,0 +1,22 @@
+import EventedMixin from '../../mixins/evented';
+import CoreObject from '../../system/core_object';
+
+QUnit.module('Ember.Evented');
+
+QUnit.test('works properly on proxy-ish objects', function(assert) {
+  let eventedProxyObj = CoreObject.extend(EventedMixin, {
+    unknownProperty() {
+      return true;
+    }
+  }).create();
+
+  let noop = function() {};
+
+  eventedProxyObj.on('foo', noop);
+  eventedProxyObj.off('foo', noop);
+
+  assert.ok(
+    true,
+    "An assertion was triggered"
+  );
+});