Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when calling inject(). #15905

Merged
merged 2 commits into from
Dec 2, 2017
Merged

Improve error message when calling inject(). #15905

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d354a72
Improve error message when calling `inject()`.
chriskrycho Dec 1, 2017
6dc2537
Fix lint, assert behavior in inject assertion.
chriskrycho Dec 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/ember-runtime/lib/inject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ import { assert } from 'ember-debug';
@public
*/
export default function inject() {
assert(`Injected properties must be created through helpers, see '${Object.keys(inject).join('"', '"')}'`);
const helpers = Object.keys(inject)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should inlined inside assert else it won't be stripped

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered about that, and can push an update to that effect tomorrow.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would solve the linting problem as well. Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

.map(k => `'inject.${k}'`)
.join(' or ');
assert(`Injected properties must be created through helpers, see '${helpers}'`);
}

// Dictionary of injection validations by type, added to by `createInjectionHelper`
Expand Down