Improve error message when calling inject().
#15905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bekzod
reviewed
Dec 1, 2017
packages/ember-runtime/lib/inject.js
Outdated
| @@ -10,7 +10,10 @@ import { assert } from 'ember-debug'; | |||
| @public | |||
| */ | |||
| export default function inject() { | |||
| assert(`Injected properties must be created through helpers, see '${Object.keys(inject).join('"', '"')}'`); | |||
| const helpers = Object.keys(inject) | |||
There was a problem hiding this comment.
I think this should inlined inside assert else it won't be stripped
There was a problem hiding this comment.
I wondered about that, and can push an update to that effect tomorrow.
There was a problem hiding this comment.
That would solve the linting problem as well. Thank you!
rwjblue
approved these changes
Dec 2, 2017
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15904