Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX release] Fix component action bubbling semantics. #14291

Merged
merged 1 commit into from
Sep 14, 2016
Merged

[BUGFIX release] Fix component action bubbling semantics. #14291

merged 1 commit into from
Sep 14, 2016

Commits on Sep 14, 2016

  1. [BUGFIX release] Fix component action bubbling semantics. 

    When a component action returns `true` we should not bubble the action
upwards (this is a significant difference between `Component#send` and
`Controller#send` / `Route#send`). The only way to get bubbling from
within a component is to call `Component#sendAction`.

This removes an invalid fallback in `ActionSupport` mixin that allowed
all component actions to bubble, and adds a few tests to help ensure we
do not regress in future refactors.
    Robert Jackson committed Sep 14, 2016
    Configuration menu
    Copy the full SHA
    ea1eeb6 View commit details
    Browse the repository at this point in the history