[BUGFIX release] Fix component action bubbling semantics. #14291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a component action returns `true` we should not bubble the action upwards (this is a significant difference between `Component#send` and `Controller#send` / `Route#send`). The only way to get bubbling from within a component is to call `Component#sendAction`. This removes an invalid fallback in `ActionSupport` mixin that allowed all component actions to bubble, and adds a few tests to help ensure we do not regress in future refactors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a component action returns
truewe should not bubble the action upwards (this is a significant difference betweenComponent#sendandController#send/Route#send). The only way to get bubbling from within a component is to callComponent#sendAction.This removes an invalid fallback in
ActionSupportmixin that allowed all component actions to bubble, and adds a few tests to help ensure we do not regress in future refactors.Fixes #14275.