[Glimmer2] Remove render env test #13399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was added to assert Glimmer 1 passed around the render env correctly. That `env` is present is an implementation detail and not public API. Since the bug motivating these assertions is tested for elsewhere, these Glimmer 1 specific tests can be removed. See also: * emberjs#11341 * emberjs@dfe32bc
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was added to assert Glimmer 1 passed around the render env correctly. That
envis present is an implementation detail and not public API. Since the bug motivating these assertions is tested for elsewhere, these Glimmer 1 specific tests can be removed.See also:
@jmurphyau @tomdale @rwjblue are probably the best parties to confirm I've got the right answer here.