Make ComponentNodeManager.rerender use RenderEnv #11341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @tomdale |
Fixes emberjs#11340. Test 'non-block with each rendering child components' in 'component_invocation_test.js' demonstrates a 'real world' test that is failing.
jmurphyau
force-pushed
the
rerender-child-with-view
branch
from
caa40c6
to
dfe32bc
Compare
|
Wasn't sure where to put the test - 'component_invocation_test.js' seems most appropriate but it looks like its getting a bit crowded.. |
rwjblue
added a commit
that referenced
this pull request
Jun 4, 2015
Make ComponentNodeManager.rerender use RenderEnv
|
Awesome job! Not sure how we missed this… @rwjblue, can we make sure this gets into beta with the other commits? ❤️ ❤️ ❤️ |
|
Yep, pulled into beta. |
mixonic
added a commit
to mixonic/ember.js
that referenced
this pull request
Apr 22, 2016
This test was added to assert Glimmer 1 passed around the render env correctly. That `env` is present is an implementation detail and not public API. Since the bug motivating these assertions is tested for elsewhere, these Glimmer 1 specific tests can be removed. See also: * emberjs#11341 * emberjs@dfe32bc
toddjordan
pushed a commit
to toddjordan/ember.js
that referenced
this pull request
Sep 9, 2016
This test was added to assert Glimmer 1 passed around the render env correctly. That `env` is present is an implementation detail and not public API. Since the bug motivating these assertions is tested for elsewhere, these Glimmer 1 specific tests can be removed. See also: * emberjs#11341 * emberjs@dfe32bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11340.
ComponentNodeManager.render()ComponentNodeManager.rerender()This causes issues in later steps where something calls
childWithViewonenv- which no longer exists.