[BUGFIX beta] Fix revalidation hook messages. #13353
Conversation
|
I need to add tests, but the lifecycle tests do not exist yet for ember-glimmer in the new structure (that is being done in #13168). I'd like to just add tests to that PR (separately from this) in an attempt to avoid writing old style tests, that then just have to be manually ported again to the new structure. Any objections? |
rwjblue
changed the title
|
#13168 has landed, I'll try to get a test added here so we can land this. |
| @@ -84,6 +84,7 @@ Renderer.prototype.dispatchLifecycleHooks = | |||
| case 'didUpdate': this.didUpdate(hook.view); break; | |||
| } | |||
|
|
|||
| ownerView._dispatching = 'didRender'; | |||
There was a problem hiding this comment.
just double checking, _dispatching is already defined in the constructor of all possible ownerView ?
There was a problem hiding this comment.
Yes, it is initialized to null by CoreView.prototype.init here.
|
☔ The latest upstream changes (presumably 3639774) made this pull request unmergeable. Please resolve the merge conflicts. |
The source of the revalidation was being lost, and the message indicated the root `ownerView` (which was not the thing that triggered a rerender). Also, the `_dispatching` flag was not being changed after calling `didInsertElement` / `didUpdateElement` and before calling `didRender`.
rwjblue
force-pushed
the
fix-deprecation-output
branch
from
387f216 to
bdca923
Compare
|
☔ The latest upstream changes (presumably #13911) made this pull request unmergeable. Please resolve the merge conflicts. |
The source of the revalidation was being lost, and the message indicated the root
ownerView(which was not the thing that triggered a rerender). Also, the_dispatchingflag was not being changed after callingdidInsertElement/didUpdateElementand before callingdidRender.Fixes #11505.
Fixes #11493.