[Glimmer 2] Implement component lifecycle hooks #13168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 tasks
wycats
force-pushed
the
lifecycle-hooks
branch
2 times, most recently
from
3c75068 to
7663789
Compare
chancancode
force-pushed
the
lifecycle-hooks
branch
from
7663789 to
bdbc922
Compare
|
☔ The latest upstream changes (presumably #13137) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Where are we at with this? |
* `willInsertElement` * `didInsertElement`
|
Finished the implementation and updated/rebased to work with latest Glimmer/Ember! 🎉 |
chancancode
changed the title
The original implementation of the hooks in HTMLBars does a deeper walk than necessary (using the AlwaysDirty validator), resulting in executing the experimental "new hooks" too often. In particular, hooks were executed downstream from the original call to `rerender()` even if the rerendering component did not use `this.set()` to update the arguments of downstream components. Because Glimmer uses a pull-based model instead of a blunt push-based model, we can avoid a deeper traversal than is necessary.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.