Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Ember.Handlebars.SafeString in favor of Ember.String.htmlSafe #13204

Merged
merged 1 commit into from
Mar 31, 2016
Merged

Deprecate Ember.Handlebars.SafeString in favor of Ember.String.htmlSafe #13204

merged 1 commit into from
Mar 31, 2016

Conversation

drewchandler
Copy link
Contributor

Addresses #13191

@drewchandler drewchandler mentioned this pull request Mar 28, 2016
Closed
@abepetrillo
Copy link
Contributor

Hey there, I added documentation to the website, but the anchor is #toc_use-ember-string-htmlsafe-over-ember-handlebars-safestring

Not sure if you want to use that or your own. PR is here: emberjs/website#2524

@rwjblue
Copy link
Member

rwjblue commented Mar 28, 2016

Sounds good, can you update that URL?

@drewchandler
Copy link
Contributor Author

@rwjblue done!

@rwjblue rwjblue merged commit 44d930c into emberjs:master Mar 31, 2016
@rwjblue
Copy link
Member

rwjblue commented Mar 31, 2016

Thank you!

@topaxi
Copy link
Contributor

topaxi commented Apr 12, 2016

How will we be able to detect htmlSafe strings now?

If Ember.Handlebars.SafeString is gone, we won't be able to do if (foo instanceof Ember.Handlebars.SafeString) { }.

@workmanw workmanw mentioned this pull request May 3, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drewchandler @abepetrillo @rwjblue @topaxi