Merge pull request #13204 from drewchandler/deprecate-ember-handlebar…

…s-safe-string Deprecate Ember.Handlebars.SafeString in favor of Ember.String.htmlSafe
emberjs · Mar 31, 2016 · 44d930c · 44d930c
2 parents bac549e + 0e95d7c
commit 44d930c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/packages/ember-htmlbars/lib/compat.js b/packages/ember-htmlbars/lib/compat.js
@@ -1,12 +1,21 @@
 import Ember from 'ember-metal/core';
+import { deprecateFunc } from 'ember-metal/debug';
 import {
   SafeString,
   escapeExpression
 } from 'ember-htmlbars/utils/string';
 
 var EmberHandlebars = Ember.Handlebars = Ember.Handlebars || {};
 
-EmberHandlebars.SafeString = SafeString;
+EmberHandlebars.SafeString = deprecateFunc(
+  'Ember.Handlebars.SafeString is deprecated in favor of Ember.String.htmlSafe',
+  {
+    id: 'ember-htmlbars.ember-handlebars-safestring',
+    until: '3.0.0',
+    url: 'http://emberjs.com/deprecations/v2.x#toc_use-ember-string-htmlsafe-over-ember-handlebars-safestring'
+  },
+  SafeString);
+
 EmberHandlebars.Utils =  {
   escapeExpression: escapeExpression
 };

diff --git a/packages/ember-htmlbars/tests/compat/safe_string_test.js b/packages/ember-htmlbars/tests/compat/safe_string_test.js
@@ -0,0 +1,9 @@
+import EmberHandlebars from 'ember-htmlbars/compat';
+
+QUnit.module('ember-htmlbars: compat - SafeString');
+
+QUnit.test('using new results in a deprecation', function(assert) {
+  expectDeprecation(function() {
+    new EmberHandlebars.SafeString('test');
+  }, 'Ember.Handlebars.SafeString is deprecated in favor of Ember.String.htmlSafe');
+});